openstack/cinder
Code Issues Proposed changes

Disallow managed volume to be managed again

Browse Source 
On manage existing volume, check if the volume is already managed.
If the volume is already managed, display an error
"Unable to manage existing volume. The volume is already managed"

Closes-bug: #1518798

Change-Id: Ide79fda590762cc040acc36987504a2bee2e85fe
This commit is contained in:
OmarM 2017-11-28 08:54:42 -05:00
parent 80558687d0
commit ff878ad0ad
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cinder/volume/api.py
View File

@ -60,7 +60,6 @@ from cinder.volume import rpcapi as volume_rpcapi
from cinder.volume import utils as volume_utils
from cinder.volume import volume_types
allow_force_upload_opt = cfg.BoolOpt('enable_force_upload',
default=False,
help='Enables the Force option on '
@ -1689,6 +1688,15 @@ class API(base.Base):
def manage_existing(self, context, host, cluster_name, ref, name=None,
description=None, volume_type=None, metadata=None,
availability_zone=None, bootable=False):
if 'source-name' in ref:
vol_id = volume_utils.extract_id_from_volume_name(
ref['source-name'])
if vol_id and volume_utils.check_already_managed_volume(vol_id):
raise exception.InvalidVolume(
_("Unable to manage existing volume."
" The volume is already managed"))
if volume_type and 'extra_specs' not in volume_type:
extra_specs = volume_types.get_volume_type_extra_specs(
volume_type['id'])