openstack/cinder
Code Issues Proposed changes

Fix: Online migrations for untyped volumes/snapshots

Browse Source 
Currently when we run online migrations with ``default_volume_type``
option set in cinder.conf, all volumes/snapshots gets migrated to
that type.
The expected functionality is to migrate them to ``__DEFAULT__`` type.
This patch fixes the same.

Change-Id: I71217621fc9426ccd88aec604ebe8d41e6f43c18
This commit is contained in:
whoami-rajat 2019-10-01 11:41:15 +05:30
parent 5b4134168f
commit ba7406d13f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinder/db/sqlalchemy/api.py
View File

@ -572,7 +572,8 @@ def service_update(context, service_id, values):
@enginefacade.writer
def untyped_volumes_online_data_migration(context, max_count):
from cinder.volume import volume_types
default_type = volume_types.get_default_volume_type()
default_type = volume_types.get_volume_type_by_name(context,
'__DEFAULT__')
# get all volumes having volume_type=None
total = 0
updated = 0
@ -596,7 +597,8 @@ def untyped_volumes_online_data_migration(context, max_count):
@enginefacade.writer
def untyped_snapshots_online_data_migration(context, max_count):
from cinder.volume import volume_types
default_type = volume_types.get_default_volume_type()
default_type = volume_types.get_volume_type_by_name(context,
'__DEFAULT__')
# get all snapshots having volume_type=None
total = 0
updated = 0