openstack/cinder
Code Issues Proposed changes

Merge "hacking: Fix false positive in C302 check"

Browse Source
This commit is contained in:
Jenkins 2016-02-09 20:25:02 +00:00 committed by Gerrit Code Review
commit a5d565b1f1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/hacking/checks.py
View File

@ -400,13 +400,16 @@ def check_datetime_now(logical_line, noqa):
yield(0, msg)
_UNICODE_USAGE_REGEX = re.compile(r'\bunicode *\(')
def check_unicode_usage(logical_line, noqa):
if noqa:
return
msg = "C302: Found unicode() call. Please use six.text_type()."
if 'unicode(' in logical_line:
if _UNICODE_USAGE_REGEX.search(logical_line):
yield(0, msg)