openstack/cinder
Code Issues Proposed changes

Address G004 in flake8-logging-format 0.7.4

Browse Source 
The current release of flake8-logging-format enforces G004 "Logging
statement uses f-string", so remove f-strings from log messages.

Change-Id: Ia87a0114738c82b2af2391bd5b4c2acb25db71fd
This commit is contained in:
Brian Rosmaita 2022-08-08 13:09:49 -04:00
parent 6dd5e20c2e
commit 9ad1bb865e
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cinder/coordination.py
View File

@ -189,11 +189,14 @@ def synchronized(lock_name: str,
t1 = timeutils.now() t1 = timeutils.now()
t2 = None t2 = None
try: try:
LOG.debug(f'Acquiring lock "{name}" by "{f_name}"') LOG.debug('Acquiring lock "%(name)s" by "%(f_name)s"',
{'name': name, 'f_name': f_name})
with lock(blocking): with lock(blocking):
t2 = timeutils.now() t2 = timeutils.now()
LOG.debug(f'Lock "{name}" acquired by "{f_name}" :: ' LOG.debug('Lock "%(name)s" acquired by "%(f_name)s" :: '
f'waited {t2 - t1:0.3f}s') 'waited %(wait)s',
{'name': name, 'f_name': f_name,
'wait': "%0.3fs" % (t2 - t1)})
return f(*a, **k) return f(*a, **k)
finally: finally:
t3 = timeutils.now() t3 = timeutils.now()
@ -202,6 +205,7 @@ def synchronized(lock_name: str,
else: else:
held_secs = "%0.3fs" % (t3 - t2) held_secs = "%0.3fs" % (t3 - t2)
LOG.debug( LOG.debug(
f'Lock "{name}" released by "{f_name}" :: held {held_secs}') 'Lock "%(name)s" released by "%(f_name)s" :: held %(held)s',
{'name': name, 'f_name': f_name, 'held': held_secs})
return _synchronized return _synchronized