openstack/cinder
Code Issues Proposed changes

hacking: Fix false positive in C302 check

Browse Source 
Use a regular expression to search for "unicode(" instead of a static
string to not complain to "exception_to_unicode(error)".

Change-Id: I0a969b184054f287cef463bbcb980bfb4a0a6803
This commit is contained in:
Victor Stinner 2016-02-09 14:56:51 +01:00
parent 3f2fe6266e
commit 917d476180
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/hacking/checks.py
View File

@ -400,13 +400,16 @@ def check_datetime_now(logical_line, noqa):
yield(0, msg) yield(0, msg)
_UNICODE_USAGE_REGEX = re.compile(r'\bunicode *\(')
def check_unicode_usage(logical_line, noqa): def check_unicode_usage(logical_line, noqa):
if noqa: if noqa:
return return
msg = "C302: Found unicode() call. Please use six.text_type()." msg = "C302: Found unicode() call. Please use six.text_type()."
if 'unicode(' in logical_line: if _UNICODE_USAGE_REGEX.search(logical_line):
yield(0, msg) yield(0, msg)