openstack/cinder
Code Issues Proposed changes

PowerMax Driver - Extend replicated volume

Browse Source 
In a replicated scenario it is possible for an R2 volume to be larger
than its paired R1 if we do not force a new volume creation on both
sides of the pair.  While using existing volumes is more efficient it
throws an exception if we want to extend the R1 to a size that is less
than or equal to the R2.

To fix this we are setting the create_new_volumes flag to true for
all replicated volumes.  It will remain false for non replicated volumes.

Change-Id: I667213a1abb025010dc306e4a012dd87c4818756
This commit is contained in:
Helen Walsh 2020-12-15 14:55:34 +00:00
parent babafa435c
commit 881f72569a
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_data.py
View File

@ -1511,7 +1511,7 @@ class PowerMaxData(object):
'expandStorageGroupParam': {
'addVolumeParam': {
'emulation': 'FBA',
'create_new_volumes': 'False',
'create_new_volumes': 'True',
'volumeAttributes': [
{'num_of_vols': 1,
'volumeIdentifier': {

3
cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_utils.py
View File

@ -1229,7 +1229,7 @@ class PowerMaxUtilsTest(test.TestCase):
'array': self.data.array,
'editStorageGroupActionParam': {
'expandStorageGroupParam': {
'addVolumeParam': {}}}}
'addVolumeParam': {'create_new_volumes': 'False'}}}}
updated_payload = self.utils.update_payload_for_rdf_vol_create(
payload, self.data.remote_array, self.data.storagegroup_name_f)
@ -1238,6 +1238,7 @@ class PowerMaxUtilsTest(test.TestCase):
'editStorageGroupActionParam': {
'expandStorageGroupParam': {
'addVolumeParam': {
'create_new_volumes': 'True',
'remoteSymmSGInfoParam': {
'force': 'true',
'remote_symmetrix_1_id': self.data.remote_array,

3
cinder/volume/drivers/dell_emc/powermax/utils.py
View File

@ -1781,6 +1781,9 @@ class PowerMaxUtils(object):
:param storage_group_name: the storage group name -- str
:returns: updated payload -- dict
"""
create_new_vol = {"create_new_volumes": "True"}
payload["editStorageGroupActionParam"]["expandStorageGroupParam"][
"addVolumeParam"].update(create_new_vol)
remote_dict = {"remoteSymmSGInfoParam": {
"remote_symmetrix_1_id": remote_array_id,
"remote_symmetrix_1_sgs": [storage_group_name],