From 850013325b50e890ad240c360c782731e6b98a56 Mon Sep 17 00:00:00 2001 From: Ryan Liang Date: Fri, 14 Jun 2019 10:50:12 +0800 Subject: [PATCH] Unity: force delete lun by default The option `force_delete_lun_in_storagegroup` was set to `False` by default before. Customers should change it to `True` in `cinder.conf` to make sure luns can be deleted even when they are still in storage groups. This fix enables the option's default value to `True`. Change-Id: I5507d280a5a68debd1f055988aa8c233b2147d09 Closes-bug: #1825469 --- cinder/volume/drivers/dell_emc/vnx/common.py | 5 ++--- .../block-storage/drivers/dell-emc-vnx-driver.rst | 2 +- .../enable-force-delete-lun-d0e05b5d669e40f7.yaml | 15 +++++++++++++++ 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 releasenotes/notes/enable-force-delete-lun-d0e05b5d669e40f7.yaml diff --git a/cinder/volume/drivers/dell_emc/vnx/common.py b/cinder/volume/drivers/dell_emc/vnx/common.py index ef27f509263..d5babb17a97 100644 --- a/cinder/volume/drivers/dell_emc/vnx/common.py +++ b/cinder/volume/drivers/dell_emc/vnx/common.py @@ -102,9 +102,8 @@ VNX_OPTS = [ 'to maximum number of pool LUNs is reached. ' 'By default, the value is False.'), cfg.BoolOpt('force_delete_lun_in_storagegroup', - default=False, - help='Delete a LUN even if it is in Storage Groups. ' - 'By default, the value is False.'), + default=True, + help='Delete a LUN even if it is in Storage Groups.'), cfg.BoolOpt('ignore_pool_full_threshold', default=False, help='Force LUN creation even if ' diff --git a/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst b/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst index f39cee18753..76b31686f13 100644 --- a/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst +++ b/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst @@ -318,7 +318,7 @@ section, the driver will move the volumes out of the storage groups and then delete them if the user tries to delete the volumes that remain in the storage group on the VNX array. -The default value of ``force_delete_lun_in_storagegroup`` is ``False``. +The default value of ``force_delete_lun_in_storagegroup`` is ``True``. Over subscription in thin provisioning -------------------------------------- diff --git a/releasenotes/notes/enable-force-delete-lun-d0e05b5d669e40f7.yaml b/releasenotes/notes/enable-force-delete-lun-d0e05b5d669e40f7.yaml new file mode 100644 index 00000000000..b011dcd0a9c --- /dev/null +++ b/releasenotes/notes/enable-force-delete-lun-d0e05b5d669e40f7.yaml @@ -0,0 +1,15 @@ +--- +upgrade: + - | + DellEMC Unity: The fix of bug + `1825469 `_ changes the + default value of the ``force_delete_lun_in_storagegroup`` option from + ``False`` to ``True``, which means luns will always be force deleted after + upgrade. +fixes: + - | + DellEMC Unity: Fix bug + `1825469 `_. The fix + enables the ``force_delete_lun_in_storagegroup`` option to ``True`` by + default, which makes sure that luns can deleted even when they are still in + storage groups.