openstack/cinder
Code Issues Proposed changes

Fix create_consistencygroup when using CG objects

Browse Source 
When create_consistencygroup receives a ConsistencyGroup object
the parsing of the volume type ids produces an extra [] which
eventually causes the database query to fail.
This is relevant only to environments that are still using CG objects
instead of VG objects.

This code should be removed in Pike, and the goal of this change is to
fix the issue when backported to Ocata.

Change-Id: I2178e051200038a83abf55b5bd62137f155596df
Closes-Bug: 1668735
This commit is contained in:
Alon Marx 2017-03-15 09:12:40 +02:00
parent 180d8fe931
commit 354b5d1ca4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py
View File

@ -1643,7 +1643,7 @@ class XIVProxy(proxy.IBMStorageProxy):
if isinstance(group, objects.Group):
volume_type_ids = group.volume_type_ids
elif isinstance(group, objects.ConsistencyGroup):
volume_type_ids = [filter(None, group.volume_type_id.split(","))]
volume_type_ids = filter(None, group.volume_type_id.split(","))
else:
msg = (_("Consistency group %(group)s has no volume_type_ids") %
{'group': cgname})