openstack/cinder
Code Issues Proposed changes

Merge "Handle NotFound exceptions in API"

Browse Source
This commit is contained in:
Jenkins 2013-10-24 20:03:41 +00:00 committed by Gerrit Code Review
commit 26c9567db6
3 changed files with 77 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
cinder/api/contrib/volume_actions.py
View File

@ -75,7 +75,11 @@ class VolumeActionsController(wsgi.Controller):
def _attach(self, req, id, body): def _attach(self, req, id, body):
"""Add attachment metadata.""" """Add attachment metadata."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
# instance uuid is an option now # instance uuid is an option now
instance_uuid = None instance_uuid = None
if 'instance_uuid' in body['os-attach']: if 'instance_uuid' in body['os-attach']:
@ -115,7 +119,11 @@ class VolumeActionsController(wsgi.Controller):
def _detach(self, req, id, body): def _detach(self, req, id, body):
"""Clear attachment metadata.""" """Clear attachment metadata."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
self.volume_api.detach(context, volume) self.volume_api.detach(context, volume)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -123,7 +131,11 @@ class VolumeActionsController(wsgi.Controller):
def _reserve(self, req, id, body): def _reserve(self, req, id, body):
"""Mark volume as reserved.""" """Mark volume as reserved."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
self.volume_api.reserve_volume(context, volume) self.volume_api.reserve_volume(context, volume)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -131,7 +143,11 @@ class VolumeActionsController(wsgi.Controller):
def _unreserve(self, req, id, body): def _unreserve(self, req, id, body):
"""Unmark volume as reserved.""" """Unmark volume as reserved."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
self.volume_api.unreserve_volume(context, volume) self.volume_api.unreserve_volume(context, volume)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -139,7 +155,11 @@ class VolumeActionsController(wsgi.Controller):
def _begin_detaching(self, req, id, body): def _begin_detaching(self, req, id, body):
"""Update volume status to 'detaching'.""" """Update volume status to 'detaching'."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
self.volume_api.begin_detaching(context, volume) self.volume_api.begin_detaching(context, volume)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -147,7 +167,11 @@ class VolumeActionsController(wsgi.Controller):
def _roll_detaching(self, req, id, body): def _roll_detaching(self, req, id, body):
"""Roll back volume status to 'in-use'.""" """Roll back volume status to 'in-use'."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
self.volume_api.roll_detaching(context, volume) self.volume_api.roll_detaching(context, volume)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -155,7 +179,11 @@ class VolumeActionsController(wsgi.Controller):
def _initialize_connection(self, req, id, body): def _initialize_connection(self, req, id, body):
"""Initialize volume attachment.""" """Initialize volume attachment."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
connector = body['os-initialize_connection']['connector'] connector = body['os-initialize_connection']['connector']
info = self.volume_api.initialize_connection(context, info = self.volume_api.initialize_connection(context,
volume, volume,
@ -166,7 +194,11 @@ class VolumeActionsController(wsgi.Controller):
def _terminate_connection(self, req, id, body): def _terminate_connection(self, req, id, body):
"""Terminate volume attachment.""" """Terminate volume attachment."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
connector = body['os-terminate_connection']['connector'] connector = body['os-terminate_connection']['connector']
self.volume_api.terminate_connection(context, volume, connector) self.volume_api.terminate_connection(context, volume, connector)
return webob.Response(status_int=202) return webob.Response(status_int=202)
@ -193,6 +225,7 @@ class VolumeActionsController(wsgi.Controller):
volume = self.volume_api.get(context, id) volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error: except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg) raise webob.exc.HTTPNotFound(explanation=error.msg)
authorize(context, "upload_image") authorize(context, "upload_image")
image_metadata = {"container_format": params.get("container_format", image_metadata = {"container_format": params.get("container_format",
"bare"), "bare"),
@ -217,7 +250,11 @@ class VolumeActionsController(wsgi.Controller):
def _extend(self, req, id, body): def _extend(self, req, id, body):
"""Extend size of volume.""" """Extend size of volume."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
try: try:
_val = int(body['os-extend']['new_size']) _val = int(body['os-extend']['new_size'])
except (KeyError, ValueError): except (KeyError, ValueError):
@ -232,7 +269,10 @@ class VolumeActionsController(wsgi.Controller):
def _volume_readonly_update(self, req, id, body): def _volume_readonly_update(self, req, id, body):
"""Update volume readonly flag.""" """Update volume readonly flag."""
context = req.environ['cinder.context'] context = req.environ['cinder.context']
volume = self.volume_api.get(context, id) try:
volume = self.volume_api.get(context, id)
except exception.VolumeNotFound as error:
raise webob.exc.HTTPNotFound(explanation=error.msg)
if not self.is_valid_body(body, 'os-update_readonly_flag'): if not self.is_valid_body(body, 'os-update_readonly_flag'):
msg = _("No 'os-update_readonly_flag' was specified " msg = _("No 'os-update_readonly_flag' was specified "

18
cinder/api/v1/volumes.py
View File

@ -379,15 +379,25 @@ class VolumeController(wsgi.Controller):
snapshot_id = volume.get('snapshot_id') snapshot_id = volume.get('snapshot_id')
if snapshot_id is not None: if snapshot_id is not None:
kwargs['snapshot'] = self.volume_api.get_snapshot(context, try:
snapshot_id) kwargs['snapshot'] = self.volume_api.get_snapshot(context,
snapshot_id)
except exception.NotFound:
explanation = _('snapshot id:%s not found') % snapshot_id
raise exc.HTTPNotFound(explanation=explanation)
else: else:
kwargs['snapshot'] = None kwargs['snapshot'] = None
source_volid = volume.get('source_volid') source_volid = volume.get('source_volid')
if source_volid is not None: if source_volid is not None:
kwargs['source_volume'] = self.volume_api.get_volume(context, try:
source_volid) kwargs['source_volume'] = \
self.volume_api.get_volume(context,
source_volid)
except exception.NotFound:
explanation = _('source vol id:%s not found') % source_volid
raise exc.HTTPNotFound(explanation=explanation)
else: else:
kwargs['source_volume'] = None kwargs['source_volume'] = None

17
cinder/api/v2/volumes.py
View File

@ -345,15 +345,24 @@ class VolumeController(wsgi.Controller):
snapshot_id = volume.get('snapshot_id') snapshot_id = volume.get('snapshot_id')
if snapshot_id is not None: if snapshot_id is not None:
kwargs['snapshot'] = self.volume_api.get_snapshot(context, try:
snapshot_id) kwargs['snapshot'] = self.volume_api.get_snapshot(context,
snapshot_id)
except exception.NotFound:
explanation = _('snapshot id:%s not found') % snapshot_id
raise exc.HTTPNotFound(explanation=explanation)
else: else:
kwargs['snapshot'] = None kwargs['snapshot'] = None
source_volid = volume.get('source_volid') source_volid = volume.get('source_volid')
if source_volid is not None: if source_volid is not None:
kwargs['source_volume'] = self.volume_api.get_volume(context, try:
source_volid) kwargs['source_volume'] = \
self.volume_api.get_volume(context,
source_volid)
except exception.NotFound:
explanation = _('source volume id:%s not found') % source_volid
raise exc.HTTPNotFound(explanation=explanation)
else: else:
kwargs['source_volume'] = None kwargs['source_volume'] = None