openstack/cinder
Code Issues Proposed changes

fix missing unit in log message

Browse Source 
Bad log message:
    "extend volume 1 to 2"
Correct one:
    "extend volume 1 GB to 2 GB"

(also update my profile in .mailmap)

Change-Id: I6d229c4440f2f5443b45a10f3912c20e21c63f32
This commit is contained in:
Kun Huang 2013-09-10 23:34:26 +08:00
parent 78544f80fa
commit 146a80fbae
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.mailmap
View File

@ -26,6 +26,7 @@
<dprince@redhat.com> <dan.prince@rackspace.com> <dprince@redhat.com> <dan.prince@rackspace.com>
<edouard1.thuleau@orange.com> <thuleau@gmail.com> <edouard1.thuleau@orange.com> <thuleau@gmail.com>
<ewan.mellor@citrix.com> <emellor@silver> <ewan.mellor@citrix.com> <emellor@silver>
<gareth@unitedstack.com> <academicgareth@gmail.com>
<ghe@debian.org> <ghe.rivero@gmail.com> <ghe@debian.org> <ghe.rivero@gmail.com>
<itoumsn@nttdata.co.jp> <itoumsn@shayol> <itoumsn@nttdata.co.jp> <itoumsn@shayol>
<jake@ansolabs.com> <jake@markupisart.com> <jake@ansolabs.com> <jake@markupisart.com>

4
cinder/volume/drivers/coraid.py
View File

@ -314,7 +314,7 @@ class CoraidAppliance(object):
return esm_result return esm_result
def resize_volume(self, volume_name, new_volume_size_in_gb): def resize_volume(self, volume_name, new_volume_size_in_gb):
LOG.debug(_('Resize volume "%(name)s" to %(size)s') % LOG.debug(_('Resize volume "%(name)s" to %(size)s GB.') %
{'name': volume_name, {'name': volume_name,
'size': new_volume_size_in_gb}) 'size': new_volume_size_in_gb})
repository = self.get_volume_repository(volume_name) repository = self.get_volume_repository(volume_name)
@ -332,7 +332,7 @@ class CoraidAppliance(object):
'args': 'resize'} 'args': 'resize'}
esm_result = self.esm_command(request) esm_result = self.esm_command(request)
LOG.debug(_('Volume "%(name)s" resized. New size is %(size)s') % LOG.debug(_('Volume "%(name)s" resized. New size is %(size)s GB.') %
{'name': volume_name, {'name': volume_name,
'size': new_volume_size_in_gb}) 'size': new_volume_size_in_gb})
return esm_result return esm_result

2
cinder/volume/drivers/rbd.py
View File

@ -810,5 +810,5 @@ class RBDDriver(driver.VolumeDriver):
LOG.error(msg) LOG.error(msg)
raise exception.VolumeBackendAPIException(data=msg) raise exception.VolumeBackendAPIException(data=msg)
LOG.debug(_("Extend volume from %(old_size)s to %(new_size)s"), LOG.debug(_("Extend volume from %(old_size)s GB to %(new_size)s GB."),
{'old_size': old_size, 'new_size': new_size}) {'old_size': old_size, 'new_size': new_size})

2
cinder/volume/drivers/sheepdog.py
View File

@ -197,7 +197,7 @@ class SheepdogDriver(driver.VolumeDriver):
LOG.error(msg) LOG.error(msg)
raise exception.VolumeBackendAPIException(data=msg) raise exception.VolumeBackendAPIException(data=msg)
LOG.debug(_("Extend volume from %(old_size)s to %(new_size)s"), LOG.debug(_("Extend volume from %(old_size)s GB to %(new_size)s GB."),
{'old_size': old_size, 'new_size': new_size}) {'old_size': old_size, 'new_size': new_size})
def backup_volume(self, context, backup, backup_service): def backup_volume(self, context, backup, backup_service):

2
cinder/volume/drivers/windows/windows.py
View File

@ -221,7 +221,7 @@ class WindowsDriver(driver.ISCSIDriver):
def extend_volume(self, volume, new_size): def extend_volume(self, volume, new_size):
"""Extend an Existing Volume.""" """Extend an Existing Volume."""
old_size = volume['size'] old_size = volume['size']
LOG.debug(_("Extended volume from %(old_size)s to %(new_size)s"), LOG.debug(_("Extend volume from %(old_size)s GB to %(new_size)s GB."),
{'old_size': old_size, 'new_size': new_size}) {'old_size': old_size, 'new_size': new_size})
additional_size = (new_size - old_size) * 1024 additional_size = (new_size - old_size) * 1024
self.utils.extend(volume['name'], additional_size) self.utils.extend(volume['name'], additional_size)