openstack/ceilometer
Code Issues Proposed changes

remove sample sorting

Browse Source 
this does nothing. the listener currently consumes events across
all queues, drops them into an 'incoming' queue. from here, a thread
batches them based on batch options. the batched messages themselves
are still in order and therefore sorting it does nothing.

the only reason it'd be out of order is if a message was requeue'd.
in this case, sorting will probably do nothing since the requeue'd location
is probably not remotely close to original ordering and will probably
never be batched with same messages to sort correctly.

Change-Id: I6faa97bb90bee00ec94f4faf622822ea93655efb
This commit is contained in:
gord chung 2017-11-15 18:00:20 -05:00 committed by gordon chung
parent 47033f5ac1
commit f24bed66a0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ceilometer/pipeline/sample.py
View File

@ -11,7 +11,6 @@
# License for the specific language governing permissions and limitations
# under the License.
from itertools import chain
from operator import methodcaller
from oslo_log import log
from stevedore import extension
@ -81,7 +80,7 @@ class InterimSampleEndpoint(base.NotificationEndpoint):
s, self.conf.publisher.telemetry_secret)
]
with self.publisher as p:
p(sorted(samples, key=methodcaller('get_iso_timestamp')))
p(samples)
class SampleSource(base.PipelineSource):