From 27e1532420e95cab651fc8a1dde6d20ca7f5b8c3 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Fri, 10 Jan 2025 19:24:02 +0900 Subject: [PATCH] Use constants to validate sample type Use the existing constants of sample types instead of hard-coding the values, to maintain the supported values in a single place. Also drop the unnecessary required option. The sample-type option has its default value so is not really required. Change-Id: I3212a5ba4a8afdf43d8ad4e95b7d958eda5428f8 --- ceilometer/cmd/sample.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ceilometer/cmd/sample.py b/ceilometer/cmd/sample.py index 9d692307e5..ce9750261b 100644 --- a/ceilometer/cmd/sample.py +++ b/ceilometer/cmd/sample.py @@ -36,9 +36,9 @@ def send_sample(): required=True), cfg.StrOpt('sample-type', short='y', - help='Meter type (gauge, delta, cumulative).', - default='gauge', - required=True), + help='Meter type.', + default=sample.TYPE_GAUGE, + choices=sample.TYPES), cfg.StrOpt('sample-unit', short='U', help='Meter unit.'),