From 787415f0c50d690485691d88189b1c545d59adf2 Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Mon, 27 Nov 2023 09:16:59 -0800
Subject: [PATCH] Update Gerrit 3.8 images to 3.8.3

Gerrit has released a 3.8.3 bugfix release. The release notes cover the
changes [0] made. In addition to the listed changes we should also pull
in a bugfix for change submissions failing due to a null account field
in metrics gathering. The reason for this is we actually build
stable-3.8 and not off of the 3.8.3 tag and this bugfix was included
after the bugfix release. Basically we build latest stable rather than
the tagged release.

We should probably keep an eye on general performance as we may need to
modify cache maxAge and refresh settings due to these being honored by
persistent caches now. Otherwise this update should be pretty
straightforward.

[0] https://www.gerritcodereview.com/3.8.html#383

Change-Id: I1d25645b84ed98d18f4b8246831623e767b5932d
---
 zuul.d/docker-images/gerrit.yaml | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/zuul.d/docker-images/gerrit.yaml b/zuul.d/docker-images/gerrit.yaml
index 51ebf9aa97..5966a31caa 100644
--- a/zuul.d/docker-images/gerrit.yaml
+++ b/zuul.d/docker-images/gerrit.yaml
@@ -61,11 +61,11 @@
         override-checkout: stable-3.8
       # Backend behavior plugins
       - name: gerrit.googlesource.com/plugins/commit-message-length-validator
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/delete-project
         override-checkout: stable-3.8
       - name: gerrit.googlesource.com/plugins/hooks
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/its-base
         # There is no 3.8 branch
         override-checkout: master
@@ -73,29 +73,29 @@
         # There is no 3.8 branch
         override-checkout: master
       - name: gerrit.googlesource.com/plugins/plugin-manager
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/replication
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/reviewnotes
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/singleusergroup
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/webhooks
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       # UI behavior plugins
       - name: gerrit.googlesource.com/plugins/codemirror-editor
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/download-commands
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/gitiles
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
       - name: gerrit.googlesource.com/plugins/zuul-results-summary
         override-checkout: main
       # Non plugin submodules
       - name: gerrit.googlesource.com/jgit
         override-checkout: master
       - name: gerrit.googlesource.com/polymer-bridges
-        override-checkout: v3.8.2
+        override-checkout: v3.8.3
     vars: &gerrit_vars_3_8
       docker_images:
         - context: docker/gerrit/bazel