Fix some puppetmaster gotchas.

Need /usr/bin/test.
Rename openstack_project::jenkins_slave to openstack_project::slave to
deal with scoping issues.

Change-Id: Ia703cdd0407eef4afe4c6cf07263150699cc47c9

manifests/site.pp

@@ -91,7 +91,7 @@ node /^ci-backup-.*\.openstack\.org$/ {
 # Test cgroups and ulimits on precise8
 node 'precise8.slave.openstack.org' {
   include openstack_project::puppet_cron
-  include openstack_project::jenkins_slave
+  include openstack_project::slave
 
   include ulimit
   ulimit::conf { 'limit_jenkins_procs':
@@ -105,7 +105,7 @@ node 'precise8.slave.openstack.org' {
 
 node /^.*\.slave\.openstack\.org$/ {
   include openstack_project::puppet_cron
-  include openstack_project::jenkins_slave
+  include openstack_project::slave
 }
 
 node /^.*\.jclouds\.openstack\.org$/ {

modules/openstack_project/manifests/base.pp

@@ -36,7 +36,7 @@ class openstack_project::base {
   }
   exec { "dpkg:puppetlabs-release-${lsbdistcodename}.deb":
     command => "/usr/bin/dpkg -i /root/puppetlabs-release-${lsbdistcodename}.deb",
-    onlyif => "test ! -f /etc/apt/sources.list.d/puppetlabs.list",
+    onlyif => "/usr/bin/test ! -f /etc/apt/sources.list.d/puppetlabs.list",
     require => Exec["download:puppetlabs-release-${lsbdistcodename}.deb"],
   }
 }

modules/openstack_project/manifests/jclouds_slave.pp

@@ -3,7 +3,7 @@
 class openstack_project::jclouds_slave {
   include openstack_project::base
 
-  class { '::jenkins_slave':
+  class { 'jenkins_slave':
     ssh_key => "",
     user => false
   }

modules/openstack_project/manifests/pypi.pp

@@ -1,6 +1,9 @@
 class openstack_project::pypi {
+  include tmpreaper
+  include apt::unattended-upgrades
+
   # include jenkins slave so that build deps are there for the pip download
-  class { '::jenkins_slave':
+  class { 'jenkins_slave':
     ssh_key => "",
     user => false
   }

modules/openstack_project/manifests/slave.pp

@@ -1,10 +1,10 @@
-class openstack_project::jenkins_slave {
+class openstack_project::slave {
   include tmpreaper
   include apt::unattended-upgrades
   class { 'openstack_project::server':
     iptables_public_tcp_ports => []
   }
-  class { '::jenkins_slave':
+  class { 'jenkins_slave':
     ssh_key => $openstack_project::jenkins_ssh_key
   }
 }