opendev/glean
Code Issues Proposed changes

Always define link_type in debian interfaces

Browse Source 
The existing code continues when an unknown link_type is found,
unfortunately we don't set link_type when the link_type is not known so
we get a python error. Just set link_type to None when we can't
determine what it is to allow the continue to function as intended.

Change-Id: Ib41650e92f24050efbc9358a6adc68421ae8a8e4
This commit is contained in:
Clark Boylan 2017-03-23 16:57:28 -07:00
parent 3e70cc9abf
commit 647f4af000
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glean/cmd.py
View File

@ -602,6 +602,8 @@ def write_debian_interfaces(interfaces, sys_interfaces):
link_type = "inet6"
elif interface['type'] == 'ipv4':
link_type = "inet"
else:
link_type = None
# We do not know this type of entry
if not link_type: