opendev/git-restack
Code Issues Proposed changes

Use 'no_proxy' env variable in addition to uppercase

Browse Source 
Need to override both variations of the no_proxy environment variable
since some tools do not check for the other if one is already defined.

While 'no_proxy' appears to be now the most common convention, it is
safer to set both lower and upper case to the same value when running
unit tests.

Change-Id: I536b6f2711ac70e0a2a45676098fb461ab3b8d33
This commit is contained in:
Darragh Bailey 2014-11-04 16:17:34 +00:00
parent e31646b3f2
commit e2bd0f5f3c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git_review/tests/__init__.py
View File

@ -167,7 +167,7 @@ class BaseGitReviewTestCase(testtools.TestCase, GerritHelpers):
'--name', 'test/test_project')
# ensure user proxy conf doesn't interfere with tests
os.environ['NO_PROXY'] = '*'
os.environ['no_proxy'] = os.environ['NO_PROXY'] = '*'
# prepare repository for the testing
self._run_git('clone', self.project_uri)