opendev/elastic-recheck
Code Issues Proposed changes

Clarify required parameters in query_builder

Browse Source 
All parameters in query_builder.result_ready are needed, so remove
default value of None. Defaulting these values to None can hide bugs
where not enough parameters are passed in.

Change-Id: Ib6aee3ec1f39ff8fa9a221b118e157e5326d1c6b
This commit is contained in:
Joe Gordon 2014-01-19 19:21:23 -08:00
parent 8c57a4f639
commit 49c5f15e84
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
elastic_recheck/query_builder.py
View File

@ -59,7 +59,7 @@ def generic(raw_query, facet=None):
return query
def result_ready(review=None, patch=None, name=None, short_build_uuid=None):
def result_ready(review, patch, name, short_build_uuid):
"""A query to determine if we have a failure for a particular patch.
This is looking for a particular FAILURE line in the console log, which